update smokehouse PWA expectations #2443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brendankenny
commented
Jun 5, 2017
| @@ -67,7 +67,7 @@ class ManifestValues extends ComputedArtifact { | |||
| { | |||
| id: 'shortNameLength', | |||
| failureText: 'Manifest `short_name` will be truncated when displayed on the homescreen', | |||
| validate: manifest => manifest.value.short_name.value && | |||
| validate: manifest => !!manifest.value.short_name.value && | |||
There was a problem hiding this comment.
added the !! so that it's always a boolean. If the site had no short_name, this would return undefined which would then get JSON.stringified out of existence in the JSON report
ebidel
approved these changes
Jun 5, 2017
paulirish
approved these changes
Jun 6, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updates the PWA smokehouse run so that it runs all the latest PWA checks (and will stay current with them going forward) and updates expectations to match