-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compact the license headers #2444
Conversation
* limitations under the License. | ||
* @license Copyright 2016 Google Inc. All Rights Reserved. | ||
* Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 | ||
* Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. | ||
*/ | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we've got quite the smattering of 'use strict' huh?
cool, fine by me |
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
* @license Copyright 2016 Google Inc. All Rights Reserved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what's the deal with github bolding/not bolding Copyright
in js/ts ha
7afe2fe
to
0f03c47
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
improve the developer experience. Less scrolling. A higher signal:noise ratio of the sourcebase.
I still maintain that you're the only person on earth who cares about this, but I also don't care. This version is at least nicer looking than the other one.
Per @brendankenny's demands, there is no extra newline between them.
after I was asked about it! I can only assume this was to make me party to this PR :P
damn straight! 😅 |
Followup from #1771 ... And spiritually part of #2276
Primary motivation here: improve the developer experience. Less scrolling. A higher signal:noise ratio of the sourcebase.
While it's easy for experienced eyes to gloss over it, the large license header acts as micro-barrier for new contributors and code voyeurs. IMO, this is a worthwhile step to improve the visual accessibility of the code.
build-traceviewer-module.js
!)'use strict';
. Per @brendankenny's demands, there is no extra newline between them.