upgrade rimraf to latest #2641
Merged
upgrade rimraf to latest #2641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samccone
approved these changes
Jul 5, 2017
|
nice! |
patrickhulce
approved these changes
Jul 5, 2017
|
hey people, when will this be published? |
|
@joaomilho this was shipped in chrome launcher already: 0.3.1 we didn't ship a lighthouse with it just yet. that'll happen later this week. |
|
yesh, I saw that :D thanks! |
paulirish
added a commit
to GoogleChrome/chrome-launcher
that referenced
this pull request
Aug 29, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2618, isaacs/rimraf#155, jestjs/jest#3942
I bisected and rimraf did fix this EPERM bug as of 2.3.0. it was one of these commits: isaacs/rimraf@v2.2.8...v2.3.0
but i'm bumping all the way to 2.6.1 because why not