refactor: extract computeLogNormalScore method #2710
Conversation
|
Niice. Good call. |
|
yeah I had a branch that copied/pasted this 2 more times and just thought enough is enough haha |
lighthouse-core/audits/audit.js
Outdated
| * @param {number} medianValue | ||
| * @return {number} | ||
| */ | ||
| static computeScore(measuredValue, diminishingReturnsValue, medianValue) { |
There was a problem hiding this comment.
since not all audits compute their score this way, would it make more sense for this to live in statistics.js still? and/or a more specific method name
There was a problem hiding this comment.
since not all audits compute their score this way
ah, but they should :) any more specific name ideas, computeLogNormalScore?
There was a problem hiding this comment.
that's probably good if it stays in audit.js. It would be good to note in the jsdoc description something about that it returns the percentage of sites with values higher than measuredValue from the distribution with the given attributes. But englished good.
patrickhulce
changed the title
No description provided.