Update smokehouse audit/gathere config to speedup lighthouse #2732
Conversation
|
Quote from @brendankenny from the previous PR which I believe is a pretty good point. Any suggestions here?
|
| module.exports = { | ||
| extends: 'lighthouse:default', | ||
| settings: { | ||
| onlyAudits: [ |
There was a problem hiding this comment.
could we do onlyCategory best-practices or does that push the number of passes up?
There was a problem hiding this comment.
did a few runs and almost no runs, It's about 2-3 audits more which don't do much
|
re: brendan's comments, let's take the one that already takes the longest/has to do the most passes and make that run the default config :) |
|
I updated the tricky ttci test As it only runs one site & takes quite some time already. |
There was a problem hiding this comment.
great stuff @wardpeet!
Just weigh in on the one comment and I think we can land
| * Config file for running PWA smokehouse audits. | ||
| */ | ||
| module.exports = { | ||
| extends: 'lighthouse:default', |
There was a problem hiding this comment.
just remove this file and run the default in tricky-ttci/run-tests.sh? Unless you think it's better if it has its own file for future changes or whatever
There was a problem hiding this comment.
nah doesn't matter, we can just extend it again when we need it.
|
🏇 🏎 ⏱ |
First part of travis speedup. Smokehouse only uses audits that are necessary.