Fix errors inside spawnPromise being ignored #2939
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrickhulce
suggested changes
Aug 10, 2017
There was a problem hiding this comment.
great catch thanks very much for the PR @alexhorn!
would you mind adding a test for this behavior in chrome-launcher/test/chrome-launcher-test.ts so we don't regress?
|
I have now added a test |
|
@patrickhulce Is this ok? |
|
@alexhorn yep looks great thanks for the ping and the contribution! :) |
patrickhulce
approved these changes
Aug 18, 2017
paulirish
pushed a commit
to GoogleChrome/chrome-launcher
that referenced
this pull request
Aug 29, 2017
…#2939) * Fix errors inside spawnPromise being ignored * Add unit test for empty chromePath * Fix formatting * Trigger rebuild
paulirish
pushed a commit
to GoogleChrome/chrome-launcher
that referenced
this pull request
Aug 29, 2017
…#2939) * Fix errors inside spawnPromise being ignored * Add unit test for empty chromePath * Fix formatting * Trigger rebuild
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an error inside spawnPromise occurs it is being ignored as the async function is passed to new Promise(...) as a regular function.
This leads to the following output if you pass an empty string for chromePath: