Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

report(render-blocking-stylesheets): improve actionability of description #3544

Merged
merged 2 commits into from
Oct 12, 2017
Merged

report(render-blocking-stylesheets): improve actionability of description #3544

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6b4185a
report(render-blocking-stylesheets): improve actionability of descrip…
paulirish Oct 12, 2017
afe4885
Update link-blocking-first-paint.js
paulirish Oct 12, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions lighthouse-core/audits/dobetterweb/link-blocking-first-paint.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,9 +30,9 @@ class LinkBlockingFirstPaintAudit extends Audit {
name: 'link-blocking-first-paint',
description: 'Reduce render-blocking stylesheets',
informative: true,
helpText: 'Link elements are blocking the first paint of your page. Consider ' +
'inlining critical links and deferring non-critical ones. ' +
'[Learn more](https://developers.google.com/web/tools/lighthouse/audits/blocking-resources).',
helpText: 'External stylesheets are blocking the first paint of your page. Consider ' +
'extracting critical CSS and delivering via `<style>` tags and deferring non-critical ' +
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To make it simpler, wdyt about just "Consider delivering critical CSS via <style> tags and deferring..."

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DONE

'styles. [Learn more](https://developers.google.com/web/tools/lighthouse/audits/blocking-resources).',
requiredArtifacts: ['TagsBlockingFirstPaint', 'traces'],
};
}
Expand Down