-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
core(lantern): move metrics to computed artifacts #4766
Merged
Merged
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
f7c0324
core(lantern): move metrics to computed artifacts
patrickhulce 43e6ffe
"es8 isn't a real thing" - paulirish
patrickhulce 5f34338
Merge branch 'master' into move_predictive_perf_artifact
patrickhulce 17be96d
Merge branch 'master' into move_predictive_perf_artifact
patrickhulce be7b1d3
typecheck!
patrickhulce d4d2b5f
move to lantern- prefix
patrickhulce 0be326d
Merge branch 'master' into move_predictive_perf_artifact
patrickhulce 9d64fa9
remove tern
patrickhulce 6a75bf8
cleanup d.ts file
patrickhulce 413ec5d
feedback
patrickhulce ad61451
cleanup timeInMs rewrite business
patrickhulce 4c8cdc4
Merge branch 'master' into move_predictive_perf_artifact
patrickhulce d794222
s/TaskMultiplier/SlowdownMultiplier
patrickhulce d8296eb
log extension test error
patrickhulce 4694b1f
fix extension gulp
patrickhulce 25e0650
last feedback
patrickhulce File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
set to undefined?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unfortunately that won't have the same effect, gotta love JS key existence vs. undefined biting us left and right 😆
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should probably keep an eye on performance then, but hopefully properties on simulatorOptions aren't the bottleneck anyways... :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤣 🤣 🤣