Adds auto-requested geolocation audit #510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -76,3 +76,6 @@ Artifacts.prototype.Speedline; | |||
|
|
|||
| /** @type {{scrollWidth: number, viewportWidth: number}} */ | |||
| Artifacts.prototype.ContentWidth; | |||
|
|
|||
| /** @type {boolean} */ | |||
| Artifacts.prototype.Geolocation; | |||
There was a problem hiding this comment.
more descriptive name for this? GeolocationOnStartup or something?
|
reviewed! |
|
Rebased and comments addressed. PTAL. |
|
This wfm, but will defer to brendan |
| * represents a poor user experience, since it lacks context. As such, if the page requests | ||
| * geolocation the gatherer will intercept the call and mark a boolean flag to true. The audit that | ||
| * corresponds with this gatherer then checks for the flag. | ||
| * @author Paul Lewis |
|
🌏 🌍 🔭 🚫 |
| } | ||
|
|
||
| function collectGeoState() { | ||
| __returnResults(window.__didNotCallGeo); |
There was a problem hiding this comment.
@paullewis: fyi, @paulirish removed the timeout in the last commit since evaluateAsync is already async and afterPass should only be called once all possible load listeners are called. Should automatically cover any expanded trace time when/if we extend the tracing time to e.g. better test TTI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: https://developers.google.com/web/fundamentals/getting-started/principles/usability-and-form-factor?hl=en#be-clear-why-you-need-a-users-location
This adds an audit for pages that automatically request geolocation on load. It's a proto for
getUserMediaand push messages, both of which should also not be requested outside of user interactions.