Restore smoketest for offline-ready SW page #518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…etween cache population and lighthouse's gatherer.
paulirish
changed the title
|
This smoketest is now up and running. Really basic sw page and we validate it's a-ok. Ready for review |
* smoketest: do full default run against our basic html page. * rename config
…e/lighthouse into offlinereadypageforsmoketest
|
We are looking good here. We now have a better platform for our smoketests, including a node-based webserver that we can configure. This means it'll be straightforward to write some fast smoketests for redirects and all the start_url/cache oddness that has cropped up. |
| // We use an image that takes 2-seconds to load to delay window onload. | ||
| // (Also about that document.write.. Bless me Souders for I have sinned...) | ||
| document.write(` | ||
| <img src="http://1.cuzillion.com/bin/resource.cgi?type=gif&sleep=2&n=1&t=${Date.now()}"> |
There was a problem hiding this comment.
yeah, this seems crazy, especially because we control our own server. Could you instead make an endpoint in static-server.js that supports this?
|
mostly looks good. Shame that this moves us away from the general solution to #307, but so great to have the smoke test back |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The smoketest is flaky with mojibrush. This change will use a localhost page instead, hopefully resolving network concerns.