-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
core(seo): support japanese in link-text audit #5322
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
|
signed it!
|
CLAs look good, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
generally I like this. We're moving towards real localization, but until then reusing the same file is OK.
cc @agektmr do these look good to you? If so, any links with these phrases should be improved to have more context. (e.g. 'Click here' => 'Understand our pricing') |
@paulirish I changed that lang file move config folder. please check. |
I'm not an expert on this field, but not sure if "全文表示" (display all), "続きを読む" (continue reading) and "もっと読む" (read more) are kind of link text to be avoided. It seems a lot of publishers use these link text on their CMS template. If they would have to replace them with concrete text, could be a challenge. Is there any criteria for English blocklist? I think same thing goes to "learn more" for example. |
@agektmr thanks for review. The website that reached 100 point in item of PWA is too minority now. But I think this check item make web more valuable. ( and get 100 point is very easy more than the Performance ) |
lint link-text is great!! I think that it will more wonderful if it supports multiple languages. I added Japanese easily. But I think this should be separate file, and that various people should be involved in editing. Please let the opinion. thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the language file change was a little too complicated for the current need, so I reverted that last commit to keep the simpler flat blocklist.
I'm kind of in favor of landing this and leaving criteria of the list to further discussion in the future. The bar seems just as arbitrary in English, so that seems fine.
@paulirish are you still good?
I missed @paulirish's 👍 |
Summary
lint link-text is great!! I think that it will more wonderful if it supports multiple languages.
I added Japanese easily. But I think this should be separate file, and that various people should be involved in editing.
Please let the opinion.
thanks.