smoketest: do full default run against our basic html page. #534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| offline200result="URL responds with a 200 when offline" | ||
|
|
||
| $NODE lighthouse-cli $flags http://localhost:9999/online-only.html > results | ||
| # run default lighthouse run against a boring basic page | ||
| $NODE lighthouse-cli --quiet http://localhost:10200/online-only.html > results |
There was a problem hiding this comment.
any reason to add --quiet? It's reassuring to see the log output in there :)
There was a problem hiding this comment.
IMO it makes it harder to go through the travis logs and I've not yet debugged a smoketest via its logs.
|
question but LGTM otherwise |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the same as #528 but against master, as the SW smoketest still stuck on our shared port SW origin matching issue #532
I want this in before we pull #531 again