Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handles ports for SW. #535

Merged
merged 2 commits into from
Jul 27, 2016
Merged

Handles ports for SW. #535

merged 2 commits into from
Jul 27, 2016

Conversation

paullewis
Copy link
Contributor

SW check needs ports.

Fixes #532

@paulirish
Copy link
Member

paulirish commented Jul 27, 2016

If you're up for it we could use whatwg-url package to normalize our url parsing everywhere.
It can also be added to our browserify excludes.

Here's it in action:

https://tonicdev.com/5798e3b9edc3e41200aaa828/5798f15349cba51300e86a05

@wardpeet
Copy link
Collaborator

For the few times we use url parsing I wouldn't introduce a new dependency

@paullewis
Copy link
Contributor Author

I'm undecided. Browserify already polyfills node's URL parsing IIRC, so we're consistent if less good than I'd like. I kinda agree with @wardpeet about not introducing a new dep at this stage, though as these things go it's pretty small and that.

@brendankenny
Copy link
Member

@zhaoz would have to update for this dep too, and he just got done with all that :)

@paulirish
Copy link
Member

Aiight. sg.

@paulirish paulirish merged commit 8c39f91 into master Jul 27, 2016
@paulirish paulirish deleted the portfix branch July 28, 2016 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants