Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve check for used JS features #544

Merged
merged 2 commits into from
Aug 1, 2016
Merged

Improve check for used JS features #544

merged 2 commits into from
Aug 1, 2016

Conversation

andreban
Copy link
Member

@andreban
Improve check for used JS features
23e4a8c 
- Moved check to ./lib/environment.js so it can be re-used in
  different modules
- Uses the vm module to check for the spread operator.
@brendankenny
Copy link
Member

LGTM, though now that we have a check that correctly passes v4 with --harmony, should we go back to exiting on failure of the check?

@andreban
Exit on invalid Node environment
2853635 
- Added `process.exit(1)` when the node environment is invalid.
@andreban
Copy link
Member Author

Added a process.exit(1) when the Node environment is invalid. PTAL.

@paulirish
Copy link
Member

works for me! thanks very much.

@paulirish paulirish merged commit 4f43470 into GoogleChrome:master Aug 1, 2016
@samccone
Copy link
Contributor

samccone commented Aug 1, 2016

an aside.. if we wanted to be really correct here we should use tc39's tests
https://github.com/tc39/test262/tree/master/test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@andreban @brendankenny @paulirish @samccone