Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: short_name shouldn't be required if the name is short #5449

Closed
wants to merge 1 commit into from
Closed

fix: short_name shouldn't be required if the name is short #5449

wants to merge 1 commit into from

Conversation

JoelEinbinder
Copy link
Contributor

fixes #2698

@JoelEinbinder
Copy link
Contributor Author

When searching for how to name this, apparently this PR already exists as #4860

@paulirish
Copy link
Member

shit, thanks for writing this. sorry we already have a pending PR on the topic. :/

whats your personal opinion of the position described here: https://github.com/GoogleChrome/lighthouse/pull/4860/files#diff-be2e8341c6d384f82ce2978ce12dfbf5R56

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patrickhulce patrickhulce Awaiting requested review from patrickhulce

@paulirish paulirish Awaiting requested review from paulirish

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

short_name shouldn't be required
2 participants
@JoelEinbinder @paulirish