core(i18n): import psuedo-locale json from TC

lighthouse-cli/cli-flags.js

@@ -120,8 +120,12 @@ function getFlags(manualArgv) {
         'list-trace-categories', 'view', 'verbose', 'quiet', 'help',
       ])
       .choices('locale', [
+        // Later, this could be Object.keys(require('../lighthouse-core/lib/locales/index.js'))
+        // But we'll curate the list for now..
+
         'en-US', // English
         'en-XA', // Accented English, good for testing
+        'ar-XB', // RTL English, good for testing
       ])
       .choices('output', printer.getValidOutputOptions())
       .choices('throttling-method', ['devtools', 'provided', 'simulate'])

lighthouse-core/lib/locales/index.js

@@ -9,4 +9,5 @@
 module.exports = {
   'en-US': require('./en-US.json'),
   'en-XA': require('./en-XA.json'),
+  'ar-XB': require('./ar-XB.json'),
 };

lighthouse-core/scripts/i18n/collect-strings.js

@@ -101,38 +101,6 @@ function collectAllStringsInDir(dir, strings = {}) {
   return strings;
 }
 
-/**
- * @param {Record<string, ICUMessageDefn>} strings
- */
-function createPsuedoLocaleStrings(strings) {
-  const psuedoLocalizedStrings = {};
-  for (const [key, defn] of Object.entries(strings)) {
-    const message = defn.message;
-    const psuedoLocalizedString = [];
-    let braceCount = 0;
-    let useHatForAccentMark = true;
-    for (let i = 0; i < message.length; i++) {
-      const char = message.substr(i, 1);
-      psuedoLocalizedString.push(char);
-      // Don't touch the characters inside braces
-      if (char === '{') {
-        braceCount++;
-      } else if (char === '}') {
-        braceCount--;
-      } else if (braceCount === 0) {
-        if (/[a-z]/i.test(char)) {
-          psuedoLocalizedString.push(useHatForAccentMark ? `\u0302` : `\u0301`);
-          useHatForAccentMark = !useHatForAccentMark;
-        }
-      }
-    }
-
-    psuedoLocalizedStrings[key] = {message: psuedoLocalizedString.join('')};
-  }
-
-  return psuedoLocalizedStrings;
-}
-
 /**
  * @param {LH.Locale} locale
  * @param {Record<string, ICUMessageDefn>} strings
@@ -148,9 +116,7 @@ function writeStringsToLocaleFormat(locale, strings) {
 }
 
 const strings = collectAllStringsInDir(path.join(LH_ROOT, 'lighthouse-core'));
-const psuedoLocalizedStrings = createPsuedoLocaleStrings(strings);
 console.log('Collected!');
 
 writeStringsToLocaleFormat('en-US', strings);
-writeStringsToLocaleFormat('en-XA', psuedoLocalizedStrings);
 console.log('Written to disk!');

lighthouse-core/test/lib/i18n-test.js

@@ -58,7 +58,8 @@ describe('i18n', () => {
   describe('#getRendererFormattedStrings', () => {
     it('returns icu messages in the specified locale', () => {
       const strings = i18n.getRendererFormattedStrings('en-XA');
-      expect(strings.passedAuditsGroupTitle).toEqual('P̂áŝśêd́ âúd̂ít̂ś');
+      expect(strings.passedAuditsGroupTitle).toEqual('[Þåššéð åûðîţš one two]');
+      expect(strings.scorescaleLabel).toEqual('[Šçöŕé šçåļé: one two]');
     });
   });
 });

typings/externs.d.ts

@@ -52,7 +52,7 @@ declare global {
       cpuSlowdownMultiplier?: number
     }
 
-    export type Locale = 'en-US'|'en-XA';
+    export type Locale = 'en-US'|'en-XA'|'ar-XB';
 
     export type OutputMode = 'json' | 'html' | 'csv';