Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core: fix defaultConfig UIStrings and exit code for test #5884

Merged
merged 1 commit into from
Aug 21, 2018
Merged

core: fix defaultConfig UIStrings and exit code for test #5884

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lighthouse-core/config/default-config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -441,10 +441,10 @@ const defaultConfig = {
},
};

module.exports = defaultConfig;

// Use `defineProperty` so that the strings are accesible from original but ignored when we copy it
Object.defineProperty(module.exports, 'UIStrings', {
enumerable: false,
get: () => UIStrings,
});

module.exports = defaultConfig;
2 changes: 1 addition & 1 deletion lighthouse-core/scripts/i18n/assert-strings-collected.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ cp "$collectedstringsPath" "$currentstringsPath"

colorText "Collecting strings..." "$purple"
set -x
node "$lhroot_path/lighthouse-core/scripts/i18n/collect-strings.js"
node "$lhroot_path/lighthouse-core/scripts/i18n/collect-strings.js" || exit 1
set +x

cp "$collectedstringsPath" "$freshstringsPath"
Expand Down