Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

misc(proto): Add proto definition for LHR #6183

Merged
merged 31 commits into from
Oct 16, 2018
Merged

misc(proto): Add proto definition for LHR #6183

merged 31 commits into from
Oct 16, 2018

Commits on Oct 4, 2018

  1. Initial proto definition of lhr*.

    @exterkamp
    exterkamp committed Oct 4, 2018
    Configuration menu
    Copy the full SHA
    a92af15 View commit details
    Browse the repository at this point in the history

  2. Struct details in proto, added python to convert sample into proto an… 

    …d do a round trip run.
    @exterkamp
    exterkamp committed Oct 4, 2018
    Configuration menu
    Copy the full SHA
    0b0052d View commit details
    Browse the repository at this point in the history

  3. Added comments to extern.d.ts fields.

    @exterkamp
    exterkamp committed Oct 4, 2018
    Configuration menu
    Copy the full SHA
    48b4774 View commit details
    Browse the repository at this point in the history

  4. Moved protos around and made them more nested in the .proto

    @exterkamp
    exterkamp committed Oct 4, 2018
    Configuration menu
    Copy the full SHA
    9ab2045 View commit details
    Browse the repository at this point in the history

  5. Added proto junk to yarn clean.

    @exterkamp
    exterkamp committed Oct 4, 2018
    Configuration menu
    Copy the full SHA
    f52221e View commit details
    Browse the repository at this point in the history

  6. Added in better proto README and yarn command to compile proto.

    @exterkamp
    exterkamp committed Oct 4, 2018
    Configuration menu
    Copy the full SHA
    c42bd3b View commit details
    Browse the repository at this point in the history

Commits on Oct 5, 2018

  1. Added i18n_v1 message w/ListValues.

    @exterkamp
    exterkamp committed Oct 5, 2018
    Configuration menu
    Copy the full SHA
    85a4a9e View commit details
    Browse the repository at this point in the history

  2. Removed python cleaning of i18n since ListValues doesn't need it.

    @exterkamp
    exterkamp committed Oct 5, 2018
    Configuration menu
    Copy the full SHA
    f3a69eb View commit details
    Browse the repository at this point in the history

  3. Cleaning up some docs + removing weird change to yarn changelog.

    @exterkamp
    exterkamp committed Oct 5, 2018
    Configuration menu
    Copy the full SHA
    a9beffb View commit details
    Browse the repository at this point in the history

  4. Cleaned up python validator a bit.

    @exterkamp
    exterkamp committed Oct 5, 2018
    Configuration menu
    Copy the full SHA
    a53c44e View commit details
    Browse the repository at this point in the history

  5. Review changes round 1. Newlines added, filenames changed, docs updated.

    @exterkamp
    exterkamp committed Oct 5, 2018
    Configuration menu
    Copy the full SHA
    f836339 View commit details
    Browse the repository at this point in the history

  6. Forgot the link in proto.

    @exterkamp
    exterkamp committed Oct 5, 2018
    Configuration menu
    Copy the full SHA
    0d56054 View commit details
    Browse the repository at this point in the history

Commits on Oct 9, 2018

  1. Added new proto field definitions using Wrappers to accomodate null's… 

    … and missing vals. Cleaned up python. Started to make test for json -> proto conversion.
    @exterkamp
    exterkamp committed Oct 9, 2018
    Configuration menu
    Copy the full SHA
    a3a6c77 View commit details
    Browse the repository at this point in the history

  2. Ignore empty strings in preprocessing, made config settings more gene… 

    …ric with wrappers, and added tests which PASS!
    @exterkamp
    exterkamp committed Oct 9, 2018
    Configuration menu
    Copy the full SHA
    53e9649 View commit details
    Browse the repository at this point in the history

  3. Made proto test self contained with sample_v2_round_trip json.

    @exterkamp
    exterkamp committed Oct 9, 2018
    Configuration menu
    Copy the full SHA
    0b18d1e View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' into proto-lhr

    @exterkamp
    exterkamp committed Oct 9, 2018
    Configuration menu
    Copy the full SHA
    a0759df View commit details
    Browse the repository at this point in the history

  5. Updated round trip to new strings. Made the json dump sort keys in py… 

    …thon.
    @exterkamp
    exterkamp committed Oct 9, 2018
    Configuration menu
    Copy the full SHA
    2d8b923 View commit details
    Browse the repository at this point in the history

Commits on Oct 10, 2018

  1. Forgot to sort output json keys.

    @exterkamp
    exterkamp committed Oct 10, 2018
    Configuration menu
    Copy the full SHA
    89f0563 View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2018

  1. Added crc empty children removal to preprocessing.

    @exterkamp
    exterkamp committed Oct 11, 2018
    Configuration menu
    Copy the full SHA
    fc9e227 View commit details
    Browse the repository at this point in the history

  2. Added preprocessing step to running lighthouse in LR.

    @exterkamp
    exterkamp committed Oct 11, 2018
    Configuration menu
    Copy the full SHA
    72a06c3 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into proto-lhr

    @exterkamp
    exterkamp committed Oct 11, 2018
    Configuration menu
    Copy the full SHA
    af41fae View commit details
    Browse the repository at this point in the history

  4. Added preprocessor to LR.

    @exterkamp
    exterkamp committed Oct 11, 2018
    Configuration menu
    Copy the full SHA
    7ff805c View commit details
    Browse the repository at this point in the history

  5. Merge branch 'master' into proto-lhr

    @exterkamp
    exterkamp committed Oct 11, 2018
    Configuration menu
    Copy the full SHA
    3c2fe15 View commit details
    Browse the repository at this point in the history

  6. Added LighthouseError to proto def.

    @exterkamp
    exterkamp committed Oct 11, 2018
    Configuration menu
    Copy the full SHA
    d513396 View commit details
    Browse the repository at this point in the history

  7. Changed proto-test to use the lib/preprocessor.

    @exterkamp
    exterkamp committed Oct 11, 2018
    Configuration menu
    Copy the full SHA
    6f1ce30 View commit details
    Browse the repository at this point in the history

  8. Added preprocessing tests and hardened preprocessor.

    @exterkamp
    exterkamp committed Oct 11, 2018
    Configuration menu
    Copy the full SHA
    a3330a5 View commit details
    Browse the repository at this point in the history

  9. Removed crc chain removal from preprocessing.

    @exterkamp
    exterkamp committed Oct 11, 2018
    Configuration menu
    Copy the full SHA
    7f92586 View commit details
    Browse the repository at this point in the history

Commits on Oct 12, 2018

  1. misc(proto): move scripts into scripts/ folder

    @paulirish @exterkamp
    paulirish authored and exterkamp committed Oct 12, 2018
    Configuration menu
    Copy the full SHA
    e8be8e8 View commit details
    Browse the repository at this point in the history

Commits on Oct 15, 2018

  1. Feedback from Paul. Removed python preprocessor. Added typechecking t… 

    …o js preprocessor. 1 more test. Comment fixes.
    @exterkamp
    exterkamp committed Oct 15, 2018
    2 Configuration menu
    Copy the full SHA
    95c0952 View commit details
    Browse the repository at this point in the history

  2. Switched from Popen to call, removed Popen legacy arg from first try … 

    …at calling node.
    @exterkamp
    exterkamp committed Oct 15, 2018
    Configuration menu
    Copy the full SHA
    fdf1d6d View commit details
    Browse the repository at this point in the history

  3. Made in/out in arg reading better.

    @exterkamp
    exterkamp committed Oct 15, 2018
    Configuration menu
    Copy the full SHA
    2ce9df0 View commit details
    Browse the repository at this point in the history