move SW version test to audit to use possibly redirected URL #620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
moves the search for the active service worker from a gatherer to an audit so it can use the final, possibly redirected URL of the test page (as introduced in #582). When #619 lands and the SW is registered reliably before the gatherer runs, this will allow e.g.
https://www.airhorner.comto pass the SW check.The service worker for airhorner is at
https://airhorner.com/sw.js, so it currently fails the same origin check withhttps://www.airhorner.com. This PR will properly take into account the redirect tohttps://airhorner.comand so the same origin check will pass.