core: increase Page.navigate timeout #6412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulirish
approved these changes
Oct 27, 2018
| @@ -840,6 +840,7 @@ class Driver { | |||
| // happen _after_ onload: https://crbug.com/768961 | |||
| this.sendCommand('Page.enable'); | |||
| this.sendCommand('Emulation.setScriptExecutionDisabled', {value: disableJS}); | |||
| this.setNextProtocolTimeout(30 * 1000); | |||
There was a problem hiding this comment.
These can 'race' and that's OK.
apparently not :)
Feels like we should await Page.enable and Emulation.setScriptExecutionDisabled (either they're short and it's no big deal or they're long and we need to account for them) but we can save that for another day.
connorjclark
added a commit
that referenced
this pull request
Oct 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6407