Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4.0.0-alpha.1 #6567

Merged
merged 3 commits into from
Nov 15, 2018
Merged

4.0.0-alpha.1 #6567

merged 3 commits into from
Nov 15, 2018

Conversation

paulirish
Copy link
Member

@paulirish paulirish commented Nov 15, 2018

might as well.

Copy link
Member

@brendankenny brendankenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm with double changelog removed

changelog.md Outdated

* build: fix viewer deploy ([#6449](https://github.com/googlechrome/lighthouse/pull/6449))
* timing: move timing-trace to async events ([#6440](https://github.com/googlechrome/lighthouse/pull/6440))
* increase generic protocol timeout to 10s (#6475) ([#6505](https://github.com/googlechrome/lighthouse/pull/6505))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

delete the (#6475) (my fault it's there)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or combine it with the #6531 entry above, since this was the erroneous one

changelog.md Outdated
* readme: use official appveyor badge ([#6443](https://github.com/googlechrome/lighthouse/pull/6443))
* i18n: convert accessibility audits ([#6229](https://github.com/googlechrome/lighthouse/pull/6229))

<a name="4.0.0-alpha.1"></a>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changelog is doubled up

@paulirish paulirish merged commit 6610036 into master Nov 15, 2018
@paulirish paulirish deleted the 4alpha1 branch November 15, 2018 02:21
@paulirish
Copy link
Member Author

Shipped. npm, cws, viewer. 4.0.0-alpha.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants