tests: driver test re-org phase 2 #7242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
connorjclark
approved these changes
Feb 14, 2019
| assert.equal(err.code, 'PROTOCOL_TIMEOUT'); | ||
| } | ||
| const pageDisablePromise = driver.sendCommand('Page.disable'); | ||
| jest.advanceTimersByTime(10); |
| const pageDisablePromise = driver.sendCommand('Page.disable'); | ||
| jest.advanceTimersByTime(10); | ||
|
|
||
| await expect(pageDisablePromise).rejects.toMatchObject({ |
| return driver.querySelector('invalid').then(value => { | ||
| assert.equal(value, null); | ||
| }); | ||
| it('returns null when DOM.querySelector finds no node', async () => { |
There was a problem hiding this comment.
great example of how moving all the mocking local makes things much easier to follow
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Phase 2 of 3 of driver-test re-org. This eliminates
sendCommandStubOldand moves all the tests over to fake timers.Last step is to replace
createOnceStubwith a similar mock function implementation and flesh out the gotoURL testsRelated Issues/PRs
#7212