report(redesign): toggle dark theme in menu #8843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
should i rename everything from |
paulirish
reviewed
May 3, 2019
| @@ -351,6 +351,7 @@ | |||
| <a href="#" class="report-icon report-icon--download" data-action="save-json">Save as JSON</a> | |||
| <a href="#" class="report-icon report-icon--open lh-export--viewer" data-action="open-viewer">Open in Viewer</a> | |||
| <a href="#" class="report-icon report-icon--open lh-export--gist" data-action="save-gist">Save as Gist</a> | |||
| <a href="#" class="report-icon report-icon--open lh-export--dark" data-action="toggle-dark">Toggle Dark Theme</a> | |||
There was a problem hiding this comment.
lets use a real icon for this.
lightbulb seems good. 💡
There was a problem hiding this comment.
ok but i dont love how i did it..
|
Use the lightbulb in material icons?
… |
|
@cjamcl i totally messed with your PR. can you give it a review? |
|
all good |
paulirish
approved these changes
May 6, 2019
|
fyi: i checked the |
paulirish
pushed a commit
that referenced
this pull request
May 28, 2019
This was referenced Mar 31, 2021
This was referenced May 26, 2021
This was referenced Dec 31, 2021
This was referenced Feb 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#8185
I know the drop shadow is wonky but that gets fixed in one of these other prs.