Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

misc: address release script feedback #9111

Merged
merged 2 commits into from
Jun 4, 2019
Merged

misc: address release script feedback #9111

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cd052b5
misc: address release script feedback
patrickhulce Jun 3, 2019
9346942
remove clean pristine
patrickhulce Jun 3, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 12 additions & 10 deletions docs/releasing.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,24 +44,26 @@ bash ./lighthouse-core/scripts/release/test.sh
# Package everything for publishing
bash ./lighthouse-core/scripts/release/prepare-package.sh

# Make sure you're in the Lighthouse pristine repo we just tested.
cd ../lighthouse-pristine

# Publish to NPM
npm publish

# Publish viewer
yarn deploy-viewer

# Upload the extension
node build/build-extension.js package; cd dist/extension-package/
open https://chrome.google.com/webstore/developer/edit/blipmdconlkpinefehnmjammfjpmpbjk
echo "Upload the package zip to CWS dev dashboard"
cd dist/extension-package/
echo "Upload the package zip to CWS dev dashboard..."
# Be in lighthouse-extension-owners group
# Open <https://chrome.google.com/webstore/developer/dashboard>
# Click _Edit_ on lighthouse
# _Upload Updated Package_
# Select `lighthouse-4.X.X.zip`
# Select `lighthouse-X.X.X.zip`
# _Publish_ at the bottom

# Make sure you're in the Lighthouse pristine repo we just tested.
cd ../lighthouse-pristine
# Publish to NPM
npm publish
# Publish viewer
yarn deploy-viewer

# * Tell the world!!! *
echo "Complete the _Release publicity_ tasks documented above"
```
17 changes: 0 additions & 17 deletions lighthouse-core/scripts/release/clean-pristine.sh
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion lighthouse-core/scripts/release/prepare-commit.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ echo "Version bump commit ready on the ${TXT_BOLD}$BRANCH_NAME${TXT_RESET} branc

echo "${TXT_DIM}Press any key to see the git diff, CTRL+C to exit...${TXT_RESET}"
read -n 1 -r unused_variable
git --no-pager diff HEAD^
git diff HEAD^
echo "${TXT_DIM}Press any key to push to GitHub, CTRL+C to exit...${TXT_RESET}"
read -n 1 -r unused_variable
git push -u origin "$BRANCH_NAME"
2 changes: 1 addition & 1 deletion lighthouse-core/scripts/release/test.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ echo "Running the standard test suite..."
yarn test

echo "Running the smoke tests...."
yarn smoke
yarn smoke || yarn smoke || yarn smoke

echo "Testing the CLI..."
yarn start "https://example.com" --view
Expand Down