Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clients(devtools): unset overflow in print #9274

Merged
merged 2 commits into from
Jun 25, 2019
Merged

clients(devtools): unset overflow in print #9274

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
20786e1
clients(devtools): disable height restriction in print
connorjclark Jun 24, 2019
efc03ee
fix overflow
connorjclark Jun 25, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions lighthouse-core/report/html/report-styles.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -263,6 +263,11 @@
overflow-y: scroll;
height: calc(100% - var(--topbar-height));
}
@media print {
.lh-devtools .lh-container {
height: inherit;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i tried this out and i'm not sure it fixes the issue.
rather than height, i'm pretty sure we need to unset the overflow property back to 'visible' instead.

@media print {
  .lh-devtools .lh-container {
    overflow-y: unset;
  }
}

Copy link
Collaborator Author

@connorjclark connorjclark Jun 25, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

worked for me

Try it out in this manner:

comment out the "printWindow.close()" fn, cancel the print prompt when it appears, and inspect the print window / apply these styles

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it was only barely working :)

fixed

}
}
.lh-devtools .lh-sticky-header {
/* This is normally the height of the topbar, but we want it to stick to the top of our scroll container .lh-container` */
top: 0;
Expand Down