Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: update report-wide utm_medium check for web.dev #9737

Merged
merged 1 commit into from
Sep 27, 2019
Merged

Conversation

brendankenny
Copy link
Member

#9555 made it so utm_medium=channel was added to web.dev links in addition to devsite links (and added a markdown link creation test for it), but it didn't update this secret report-renderer test, which has been skating by because it only required 20 devsite links with a utm_medium search param to be in the sample report.

That's about to start failing, so updated the test to account for the new docs origin.

Copy link
Collaborator

@patrickhulce patrickhulce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants