Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core(stack-packs): add angular, react, amp, and magento packs #9797

Merged
merged 17 commits into from
Oct 15, 2019
Merged

core(stack-packs): add angular, react, amp, and magento packs #9797

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
17d8c36
adds amp, angular, magento and react packs
housseindjirdeh Oct 7, 2019
e5aea26
adds pack artifacts
housseindjirdeh Oct 7, 2019
8b0baf1
fixes colliding strings
housseindjirdeh Oct 8, 2019
de6d852
updates stack pack icons
housseindjirdeh Oct 8, 2019
b539a41
updates sample json
housseindjirdeh Oct 8, 2019
e10f801
updates react icon
housseindjirdeh Oct 9, 2019
84eea6e
adds packs to enabled lists
housseindjirdeh Oct 9, 2019
1513b6c
adds README
housseindjirdeh Oct 9, 2019
2991267
fixes svgs
housseindjirdeh Oct 9, 2019
487a641
updates angular required stacks
housseindjirdeh Oct 9, 2019
c8fa7b1
updates library detector version
housseindjirdeh Oct 9, 2019
b583c2c
updates per comments
housseindjirdeh Oct 10, 2019
ca9c50b
updates sample json
housseindjirdeh Oct 14, 2019
004f2e7
fixes for failing smoke tests
housseindjirdeh Oct 15, 2019
220b47d
fixes yarn integrity checks
housseindjirdeh Oct 15, 2019
4c1518b
update test results
housseindjirdeh Oct 15, 2019
fea938e
remove comments and include name entry for fast path stack
housseindjirdeh Oct 15, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 15 additions & 10 deletions lighthouse-cli/test/smokehouse/dobetterweb/dbw-expectations.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,8 @@ const expectations = [
artifacts: {
Stacks: [{
id: 'jquery',
}, {
id: 'jquery', // for jquery's "fast path" stack. Multiple stacks have a second "fast path" version in the library detector
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove comment and add name: 'jQuery (Fast path)' ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove comment and add name: 'jQuery (Fast path)' ?

yeah, that might be simpler than my comment idea :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done :)

}, {
id: 'wordpress',
}],
Expand Down Expand Up @@ -184,16 +186,21 @@ const expectations = [
score: 0,
details: {
items: [
{
source: 'network',
description: 'Failed to load resource: the server responded with a status of 404 (Not Found)',
url: 'http://localhost:10200/dobetterweb/unknown404.css?delay=200',
},
{
source: 'other',
description: 'Application Cache Error event: Manifest fetch failed (404) http://localhost:10200/dobetterweb/clock.appcache',
url: 'http://localhost:10200/dobetterweb/dbw_tester.html',
},
{
source: 'Runtime.exception',
description: /^Error: A distinctive error\s+at http:\/\/localhost:10200\/dobetterweb\/dbw_tester.html:\d+:\d+$/,
url: 'http://localhost:10200/dobetterweb/dbw_tester.html',
},
{
source: 'network',
description: 'Failed to load resource: the server responded with a status of 404 (Not Found)',
url: 'http://localhost:10200/dobetterweb/unknown404.css?delay=200',
},
{
source: 'network',
description: 'Failed to load resource: the server responded with a status of 404 (Not Found)',
Expand All @@ -209,11 +216,6 @@ const expectations = [
description: 'Failed to load resource: the server responded with a status of 404 (Not Found)',
url: 'http://localhost:10200/dobetterweb/unknown404.css?delay=200',
},
{
source: 'Runtime.exception',
description: /^Error: A distinctive error\s+at http:\/\/localhost:10200\/dobetterweb\/dbw_tester.html:\d+:\d+$/,
url: 'http://localhost:10200/dobetterweb/dbw_tester.html',
},
],
},
},
Expand Down Expand Up @@ -356,6 +358,9 @@ const expectations = [
items: [{
name: 'jQuery',
},
{
name: 'jQuery (Fast path)',
},
{
name: 'WordPress',
}],
Expand Down
Loading