core(lightwallet): render timing-budget audit #9925
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khempenius
requested review from
brendankenny,
exterkamp,
patrickhulce and
paulirish
as code owners
|
Hi guys @paulirish @patrickhulce, and thanks to @khempenius for implementing budgets for timing metrics! Are there any plans for a review of this PR? |
| .lh-audit-group--budgets .lh-table tbody tr td:nth-child(5){ | ||
| .lh-audit-group--budgets #performance-budget tbody tr td:nth-child(4), | ||
| .lh-audit-group--budgets #performance-budget tbody tr td:nth-child(5), | ||
| .lh-audit-group--budgets #timing-budget tbody tr td:nth-child(3){ |
There was a problem hiding this comment.
Suggested change
| .lh-audit-group--budgets #timing-budget tbody tr td:nth-child(3){ | |
| .lh-audit-group--budgets #timing-budget tbody tr td:nth-child(3) { |
| budgetsGroupEl.classList.add('lh-audit-group--budgets'); | ||
| element.appendChild(budgetsGroupEl); | ||
| const budgetsGroupEl = this.renderAuditGroup(groups.budgets); | ||
| let showBudgetsGroup; |
There was a problem hiding this comment.
might be better to have a budgetTableEls array, push to it ~L176 (instead of append to budgetsGroupEl), and check it's non-empty before creating budgetsGroupEl.
|
Bumping this up for review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
timing-budgetto default config & renders table when applicable.Related Issues/PRs
Issue: #8917