Remove the scroll listener to stop LCP observing #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #75 by removing the
scrollandpointerdownlisteners and only relying onclickandkeydownlisteners.The implication of this change is that in some cases the browser may have stopped observing LCP changes prior to this library marking it as "final", but the benefit is LCP observations will not be incorrectly stopped early if a site programmatically calls an API like
window.scrollTo().For most developers using this API to send data to an analytics service, they should not see a difference in what is reported (except for sites that were using
window.scrollTo()and reporting incorrect data). However, anyone using the web-vitals-extension may notice that LCP is no longer marked as "final" after a user scrolls.cc: @addyosmani