StrategyHandler.doneWaiting unhandled rejection #3172
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshkel
changed the title
* updating typescript version and types * Updating dependencies types dependencies
#3215) * Updating octokit/rest and lerna * Updating mocha * Updating types * removing the lerna upgrade * update lerna to the highest version that doesn't break the tests, also fixes the critical dependency error
doneWaiting throws on the first rejected promise that it encounters. This means that subsequent rejected promises may result in unhandled rejection errors. Fixes #3171
joshkel
force-pushed
the
strategy-unhandled-rejection
branch
from
a7bc96a to
64fb188
Compare
|
Hi there, Workbox is moving to a new engineering team within Google. As part of this move, we're declaring a partial bug bankruptcy to allow the new team to start fresh. We realize this isn't optimal, but realistically, this is the only way we see it working. For transparency, here're the criteria we applied:
Thanks, and we hope for your understanding! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3171
StrategyHandler.doneWaitingthrows on the first rejected promise that it encounters. This means that subsequent rejected promises may result in unhandled rejection errors.Promise.allSettled is a natural solution. It does not appear to be supported on all browsers that workbox uses. I tried installing promise.allsettled from NPM but had trouble getting the default import from that module to work correctly with Rollup, and I noticed that the workbox service worker libraries tend to avoid external dependencies in general, so I created a local version instead. I put it under workbox-core's
_privatedirectory, following the example of other utility code such as Deferred. If I should handle this differently, please let me know.