Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add wasm to precache manifest #3321

Merged
merged 1 commit into from
May 28, 2024
Merged

Conversation

ArhanChaudhary
Copy link
Contributor

Addresses #3319

I'm not familiar with workbox's codebase, so I may have forgotten to appropriately change something

Copy link
Member

@tomayac tomayac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, approval

@tropicadri, waiting for your review before merging.

@ArhanChaudhary
Copy link
Contributor Author

I think this deserves a bump, this looks like an easy merge.

@tomayac tomayac merged commit 387a6fe into GoogleChrome:v7 May 28, 2024
2 of 3 checks passed
@tomayac
Copy link
Member

tomayac commented May 28, 2024

Agreed. Merged now.

@ArhanChaudhary ArhanChaudhary deleted the support-wasm branch May 28, 2024 08:24
@tropicadri
Copy link
Contributor

tropicadri commented May 29, 2024

@ArhanChaudhary Sorry I didn't reply any chance you can create a PR adding .wasm file examples to the affected tests for the package? Right now as expected all the tests use .js, .css and .html and I'd like the tests to match updated default.

@ArhanChaudhary
Copy link
Contributor Author

sure, i can soon take a look at that

@ArhanChaudhary ArhanChaudhary restored the support-wasm branch June 2, 2024 01:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants