Added initial TT implementation #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added comments Added "append" feature for CSP headers
|
The decrease in test coverage is due to extending the test suite to include some of the base handlers. The logic in these handlers are fully covered by the tests, the only lacking line is a Symfony core line for registering the subscribers. I can add this in but I dont think it gives any value, and only serves to bloat the tests with un-needed line coverage |
Added is acrive check Added logging for policy conflicts Changed confusing var name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #16
Added a Trusted Types implementation to the ISE Security Bundle. This does not include a full CSP module. The idea for this, after discussion in the ISE group, was to implement TT in a way that would be compatable with other bundles (i.e nelmio security bundle), and would not lead to an overwritten or broken CSP header.