Splits the project into core and cli modules
#101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Uses `lerna` to manage modules - Adds README.md for each module - Updates version to 0.4.0
andreban
force-pushed
the
split-modules-lerna
branch
from
ed48b87 to
d9a0241
Compare
PEConn
approved these changes
Feb 12, 2020
README.md
Outdated
| validate your domain. The | ||
| [TWA Quick Start Guide](https://developers.google.com/web/updates/2019/08/twas-quickstart#creating-your-asset-link-file) | ||
| explains how to extract the information needed to generate it. | ||
| - **[llama-pack-core](./packages/core):** a javascript library that for generating, building and |
| explains how to extract the information needed to generate it. | ||
| - **[llama-pack-core](./packages/core):** a javascript library that for generating, building and | ||
| updating TWA projects. | ||
| - **[llama-pack-cli](./packages/cli):** a command-line version for llama-pack. |
There was a problem hiding this comment.
A command-line "version" sounds a bit odd.
"llama-pack core wrapped for the command line" maybe?
There was a problem hiding this comment.
"command-line interface for llama-pack"?
| }, | ||
| "devDependencies": { | ||
| "@typescript-eslint/eslint-plugin": "^2.9.0", | ||
| "@typescript-eslint/parser": "^2.9.0", | ||
| "eslint": "^6.6.0", | ||
| "eslint-config-google": "^0.14.0", | ||
| "jasmine": "^3.5.0" | ||
| "jasmine": "^3.5.0", |
There was a problem hiding this comment.
So there are tests in the parent package?
There was a problem hiding this comment.
We don't. Cleaned-up the dependencies in root. We can re-add later if we end up needing.
| import {AndroidSdkTools} from './lib/androidSdk/AndroidSdkTools'; | ||
| import {Config} from './lib/Config'; | ||
| import {GradleWrapper} from './lib/GradleWrapper'; | ||
| import Log from './lib/Log'; |
There was a problem hiding this comment.
Log is using export default Log, while others simple use export. Maybe I should change Log to just use export, but likely in another PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lernato manage modules