Fix packageName generation #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fixes the regex to handle multiple invalid chars - Moves generatePackageName to util - Adds a test for multiple invalid chars Closes GoogleChromeLabs#113
PEConn
reviewed
Mar 3, 2020
packages/core/src/lib/util.ts
Outdated
| @@ -25,6 +25,10 @@ import {WebManifestIcon} from './types/WebManifest'; | |||
| const execPromise = promisify(exec); | |||
| const extractZipPromise = promisify(extractZip); | |||
|
|
|||
| // Regex for disallowed characters on Android Packages, as per | |||
| // https://developer.android.com/guide/topics/manifest/manifest-element.html#package | |||
| const DISALLOWED_ANDROID_PACKAGE_CHARS_REGEX = /[^ a-zA-Z0-9_\.]/g; | |||
There was a problem hiding this comment.
I don't think there should be a space in here.
There was a problem hiding this comment.
Yes, that shouldn't be there. Removed and added a test for input with spaces.
- Removes extra space from the regex. - Adds a test for input with spaces.
PEConn
approved these changes
Mar 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #113