-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adaptative Icons Improvements #117
Conversation
- Background for transparent icons is white. - Moves icon to the foreground layer, instead of background. Closes GoogleChromeLabs#112 Closes GoogleChromeLabs#115
@NotWoods would mind taking a quick look? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These were intentional choices to align with the spec, where Chrome deviates slightly.
-
Maskable icons should not be transparent at all. I think using black to indicate this is fine, perhaps an additional warning can be added.
-
Maskable icons don't fill 100% of the icon area, so they should be placed on the background layer to reduce parallax. (Admittedly this part was just in discussions by the spec authors and not in the spec itself.)
I believe we should align with WebAPK behavior (fill the transparent space with white color, not black). See also my #112 (comment) and #112 (comment). The first is WebAPK, the second is TWA: |
Thanks for the input, @NotWoods Regarding the white background:The spec does advise against use transparent icons for the maskable icon, but does provide guidance on how user agents should handle it:
It does seem that we could switch the fill color from black to white and remain true to the spec. This would also replicate the behaviour for WebAPKs and the Android Platform in general. Regarding the parallax effectWould you have more details on that discussion? If this is likely to make it to the spec, it may be worth keeping it as it is. Otherwise, I think making it compatible with WebAPKs and with what Android expects as a platform worth it. I'll double check how it works in WebAPKs and understand the design decisions on their side too. |
- Discussed with the WebAPK team and this is being considered to be changed in the WebAPK side. Keeping the current llama-pack behaviour.
I have discussed with the WebAPK team and reverted the icon back to the background layer, as it's currently being considered to be changed there. |
Moves icon to the foreground layer, instead of background.android.useAndroidX=true
tobuild.gradle
to make importing the project into Android Studio more seamless (unrelated to the icon).Closes #112