Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds instructions to update the CLI config #133

Merged
merged 2 commits into from
Apr 3, 2020
Merged

Conversation

andreban
Copy link
Member

@andreban andreban commented Apr 3, 2020

No description provided.

@andreban andreban merged commit 20bafa2 into master Apr 3, 2020
@andreban andreban added the enhancement New feature or request label Apr 21, 2020
### Updating the location of the JDK and / or the Android command line tools.
If the location for the JDK or the Android command line tools have been setup with the wrong path or
if their location has changed after the initial configuration, the location for either of those can
be changed by editing the configuration file at `${USER_HOME}/.llama-pack/llama-pack-config.json`.
Copy link
Contributor

@abdonrd abdonrd Apr 25, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should change the file name to .bubblewrap/bubblewrap-config.json?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There isn't a huge benefit on updating the file name and it will either cause current configs to be lost or need extra code to handle both cases.

@andreban andreban deleted the andreban-patch-1 branch October 13, 2020 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants