Improves packageId generation / validation #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- generatePackageId returns an error string when a correct package cannot be generated from the input. - validatePackageId returns an error string if the input is invalid or null if there's no error. - validateNotEmpty introduced in `core`. `notEmpty()` in `cli/inputHelpers()` uses it. - TwaGenerator#validate() changed to return an error string if the packageId is invalid or null if if it is valid. It also validates the packageId
PEConn
approved these changes
Apr 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
package cannot be generated from the input.
invalid or null if there's no error.
core.notEmpty()incli/inputHelpers()uses it.packageId is invalid or null if if it is valid. It also validates
the packageId