Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLI checks minimum supported Node.js version #160

Merged
merged 3 commits into from
May 6, 2020
Merged

CLI checks minimum supported Node.js version #160

merged 3 commits into from
May 6, 2020

Conversation

andreban
Copy link
Member

@andreban andreban commented May 5, 2020 •
edited
Loading

Uses semver to check the Node.js version and throws an error if an unsupported version is used.

Capture

Closes #152

@andreban andreban requested a review from PEConn May 5, 2020 20:28
@andreban
Copy link
Member Author

andreban commented May 5, 2020

@jotinhabr FYI, as this should help developers understand what's happening on #151

@andreban andreban added the enhancement New feature or request label May 5, 2020
@andreban andreban merged commit 1939849 into GoogleChromeLabs:master May 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PEConn PEConn PEConn approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Check for valid NodeJs version on startup
2 participants
@andreban @PEConn