Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve shortcut icon selection. #56

Merged
merged 1 commit into from
Jan 7, 2020
Merged

Improve shortcut icon selection. #56

merged 1 commit into from
Jan 7, 2020

Conversation

rayankans
Copy link
Contributor

Unify icon selection logic & fix some types.

@rayankans
Improve shortcut icon selection.
153e6d2 
Unify icon selection logic & fix some types.
@PEConn PEConn requested a review from andreban January 7, 2020 17:36
@andreban andreban merged commit 6489b21 into GoogleChromeLabs:master Jan 7, 2020
andreban
andreban reviewed Jan 7, 2020
View reviewed changes
Copy link
Member

@andreban andreban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andreban andreban added the enhancement New feature or request label Mar 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreban andreban andreban left review comments

@PEConn PEConn PEConn approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rayankans @andreban @PEConn