Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Converts TwaGenerator.js and Log.js to TypeScript #81

Merged
merged 1 commit into from
Jan 20, 2020
Merged

Converts TwaGenerator.js and Log.js to TypeScript #81

merged 1 commit into from
Jan 20, 2020

Conversation

andreban
Copy link
Member

Advances #76

@andreban andreban requested a review from PEConn January 20, 2020 20:07
PEConn
PEConn approved these changes Jan 20, 2020
View reviewed changes
src/lib/Log.ts
/**
* An utility class to print nice Log messages.
*/
export default class Log {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm surprised there's not a library to do this. Maybe there's just not a nice and small library that does this.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I kind of copied this from amp-toolbox: https://github.com/ampproject/amp-toolbox/blob/master/packages/core/lib/Log.js

@andreban andreban merged commit 357f754 into GoogleChromeLabs:master Jan 20, 2020
@andreban andreban deleted the twa-generator-typescript branch February 13, 2020 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PEConn PEConn PEConn approved these changes

Assignees
No one assigned
Labels
internal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andreban @PEConn