Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds missing private keywords #84

Merged
merged 2 commits into from
Jan 23, 2020
Merged

Adds missing private keywords #84

merged 2 commits into from
Jan 23, 2020

Conversation

andreban
Copy link
Member

  • Not exhaustive, but should cover most places.

@andreban andreban requested a review from PEConn January 23, 2020 12:02
PEConn
PEConn approved these changes Jan 23, 2020
View reviewed changes
Copy link
Collaborator

@PEConn PEConn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks good.

We could probably sprinkle a few readonlys around the place as well (though that doesn't need to block this change).

@andreban andreban merged commit 0863b4b into GoogleChromeLabs:master Jan 23, 2020
@andreban andreban deleted the private-members branch February 13, 2020 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PEConn PEConn PEConn approved these changes

Assignees
No one assigned
Labels
internal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andreban @PEConn