feat: publish play-related CLI command #885
Conversation
| // case 'playRetain': | ||
| // return await play(parsedArgs as unknown as PlayArgs, 'retain'); | ||
| case 'play': | ||
| return await play(parsedArgs as unknown as PlayArgs); |
There was a problem hiding this comment.
Hi Jakub, did you test all 4 of these new commands? I doubt that the play command would work, because the play() function requires the second parameter command. I am not sure what the original author meant by this, but I suggest deleting the two lines above.
There was a problem hiding this comment.
hey, you're right - I filed this PR rather lazily.
Check out new commit: I've move play commands into single namespace (so, all of the publish, retain, versionCheck commands are subcommands of bubblewrap play) and cleanup the implementation a bit - now it resembles other parts of the codebase more (mainly fingerprint/build commands).
I've also tested once again publish and versionCheck - they are working. Not sure about the retain - that's why I'm leaving it marked as "experimental" in the docs and in the implementation (there is an additional prompt, so the needs to confirm when they want to use an experimental feature).
What do you think?
cleanup play commands code add play commands README mark play retain command as experimental
resolves #786
Description
Even though available in the repository README, the play-related CLI commands (
play,playPublish,playVersionCheck,playRetain) are not publicly available in the CLI itself.It turns out, that the code is there already - just needs to be uncommented. They all seem to be working.
I personally use the
playPublishin my repository to fully automate publishing of my app to the Google Play (see the source here and here).