Adds web-manifest-url meta-tag and web-app-manifest.json #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- When webManifestUrl is set on twa-manifest.json, it includes a `web-manifest-url` meta-tag on AndroidManifest.xml with the correct value and creates a web-app-manifest.json at /res/raw - When webManifestUrl ist not set, it doesn't add any meta tag
PEConn
approved these changes
Feb 5, 2020
| <meta-data | ||
| android:name="cros_web_alternative" | ||
| android:value="@string/crosLaunchUrl" /> | ||
| <% if (webManifestUrl) { %> |
There was a problem hiding this comment.
Huh, I did not know we could use substitutions in the AndroidManifest.xml
There was a problem hiding this comment.
That's lodash, the template engine we're using in llama-pack.
|
@dominickng FYI |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
web-manifest-urlmeta-tag on AndroidManifest.xml with thecorrect value and creates a web-app-manifest.json at /res/raw
Closes #88