chore: fix issue with headers

GoogleChromeLabs · Sep 9, 2024 · 17ff8fd · 17ff8fd
1 parent 2c74513
commit 17ff8fd
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 28 deletions.
diff --git a/src/bidiMapper/modules/network/NetworkRequest.ts b/src/bidiMapper/modules/network/NetworkRequest.ts
@@ -88,6 +88,12 @@ export class NetworkRequest {
     bodySize?: number;
   };
 
+  #responseOverrides?: {
+    statusCode?: number;
+    headers?: Network.Header[];
+    cookies?: Network.CookieHeader[];
+  };
+
   #response: {
     hasExtraInfo?: boolean;
     info?: Protocol.Network.Response;
@@ -242,6 +248,7 @@ export class NetworkRequest {
   /** Returns the HTTP status code associated with this request if any. */
   get #statusCode(): number | undefined {
     return (
+      this.#responseOverrides?.statusCode ??
       this.#response.info?.status ??
       this.#response.extraInfo?.statusCode ??
       this.#response.paused?.responseStatusCode
@@ -634,6 +641,11 @@ export class NetworkRequest {
         responseHeaders:
           responseHeaders ?? this.#response.paused?.responseHeaders,
       });
+
+      this.#responseOverrides = {
+        statusCode: overrides.statusCode,
+        headers: overrides.headers,
+      };
     }
   }
 
@@ -824,7 +836,7 @@ export class NetworkRequest {
         this.#response.info?.fromDiskCache ||
         this.#response.info?.fromPrefetchCache ||
         this.#servedFromCache,
-      headers,
+      headers: this.#responseOverrides?.headers ?? headers,
       mimeType: this.#response.info?.mimeType || '',
       bytesReceived: this.#response.info?.encodedDataLength || 0,
       headersSize: computeHeadersSize(headers),

diff --git a/...tadata/chromedriver/headful/webdriver/tests/bidi/network/continue_response/headers.py.ini b/...tadata/chromedriver/headful/webdriver/tests/bidi/network/continue_response/headers.py.ini
@@ -8,15 +8,6 @@
   [test_headers[headers2\]]
     expected: FAIL
 
-  [test_headers_overrides_original_headers[headers0\]]
-    expected: FAIL
-
-  [test_headers_overrides_original_headers[headers1\]]
-    expected: FAIL
-
-  [test_headers_overrides_original_headers[headers2\]]
-    expected: FAIL
-
   [test_set_cookie_header]
     expected: FAIL
 

diff --git a/...adata/chromedriver/headless/webdriver/tests/bidi/network/continue_response/headers.py.ini b/...adata/chromedriver/headless/webdriver/tests/bidi/network/continue_response/headers.py.ini
@@ -8,15 +8,6 @@
   [test_headers[headers2\]]
     expected: FAIL
 
-  [test_headers_overrides_original_headers[headers0\]]
-    expected: FAIL
-
-  [test_headers_overrides_original_headers[headers1\]]
-    expected: FAIL
-
-  [test_headers_overrides_original_headers[headers2\]]
-    expected: FAIL
-
   [test_set_cookie_header]
     expected: FAIL
 

diff --git a/wpt-metadata/mapper/headless/webdriver/tests/bidi/network/continue_response/headers.py.ini b/wpt-metadata/mapper/headless/webdriver/tests/bidi/network/continue_response/headers.py.ini
@@ -8,15 +8,6 @@
   [test_headers[headers2\]]
     expected: FAIL
 
-  [test_headers_overrides_original_headers[headers0\]]
-    expected: FAIL
-
-  [test_headers_overrides_original_headers[headers1\]]
-    expected: FAIL
-
-  [test_headers_overrides_original_headers[headers2\]]
-    expected: FAIL
-
   [test_set_cookie_header]
     expected: FAIL