chore: fix auth event

src/bidiMapper/domains/network/NetworkRequest.ts

@@ -170,8 +170,8 @@ export class NetworkRequest {
     );
 
     const requestInterceptionCompleted =
-      (requestInterceptionExpected && Boolean(this.#request.paused)) ||
-      !requestInterceptionExpected;
+      !requestInterceptionExpected ||
+      (requestInterceptionExpected && Boolean(this.#request.paused));
 
     if (
       Boolean(this.#request.info) &&
@@ -194,8 +194,8 @@ export class NetworkRequest {
     );
 
     const responseInterceptionCompleted =
-      (responseInterceptionExpected && Boolean(this.#response.paused)) ||
-      !responseInterceptionExpected;
+      !responseInterceptionExpected ||
+      (responseInterceptionExpected && Boolean(this.#response.paused));
 
     if (
       this.#response.info ||
@@ -291,7 +291,8 @@ export class NetworkRequest {
     }
   }
 
-  onAuthRequired(_event: Protocol.Fetch.AuthRequiredEvent) {
+  onAuthRequired(event: Protocol.Fetch.AuthRequiredEvent) {
+    this.#fetchId = event.requestId;
     this.#interceptPhase = Network.InterceptPhase.AuthRequired;
     if (!this.blocked) {
       void this.continueWithAuth();

src/bidiMapper/domains/network/NetworkStorage.spec.ts

@@ -338,8 +338,9 @@ describe('NetworkStorage', () => {
     eventManager = new EventManager(browsingContextStorage);
     processingQueue = new ProcessingQueue<OutgoingMessage>(
       async ({message}) => {
-        const cdpEvent = message as unknown as ChromiumBidi.Event;
-        processedEvents.set(cdpEvent.method, cdpEvent.params);
+        if (message.type === 'event') {
+          processedEvents.set(message.method, message.params);
+        }
         return await Promise.resolve();
       },
       logger
@@ -537,5 +538,13 @@ describe('NetworkStorage', () => {
       expect(event).to.exist;
       request.requestWillBeSent();
     });
+
+    it('should work with only authRequired', async () => {
+      const request = new MockCdpNetworkEvents(cdpClient);
+
+      request.authRequired();
+      const event = await getEvent('network.authRequired');
+      expect(event).to.exist;
+    });
   });
 });

src/bidiMapper/domains/network/NetworkStorage.ts

@@ -322,21 +322,9 @@ export class NetworkStorage {
     cdpTarget: CdpTarget
   ) {
     // CDP quirk if the Network domain is not present this is undefined
-    const request = this.getRequestByFetchId(event.requestId);
+    let request = this.getRequestByFetchId(event.requestId);
     if (!request) {
-      // CDP quirk even both request/response may be continued
-      // with this command
-      void cdpTarget.cdpClient
-        .sendCommand('Fetch.continueWithAuth', {
-          requestId: event.requestId,
-          authChallengeResponse: {
-            response: 'Default',
-          },
-        })
-        .catch(() => {
-          // TODO: add logging
-        });
-      return;
+      request = this.#getOrCreateNetworkRequest(event.requestId, cdpTarget);
     }
 
     request.onAuthRequired(event);

src/protocol/chromium-bidi.ts

@@ -120,10 +120,6 @@ export type ResultData = WebDriverBidi.ResultData | Cdp.ResultData;
 
 export type BidiPlusChannel = string | null;
 
-export type Message = (
-  | WebDriverBidi.Message
-  | Cdp.Message
-  | {launched: true}
-) & {
+export type Message = (WebDriverBidi.Message | Cdp.Message) & {
   channel?: BidiPlusChannel;
 };