Skip to content

Commit

Permalink
docs: update WPT expectations regeneration in blink (#1568)
Browse files Browse the repository at this point in the history
docs: update WPT expectations regeneration in blink
    
Due to the remover of web_platform_tests_wptrunner.md, some links are
broken now. Fix those links with a new one.
    
We have also made a decision to not use metadata for WPTs. Updated the
instructions accordingly.
    
Bug: https://bugs.chromium.org/p/chromium/issues/detail?id=1474702
Fixed: #1306
Co-authored-by: Weizhong Xia <weizhong@google.com>
Pingback: https://crrev.com/c/5037684/

Co-authored-by: Weizhong Xia <weizhong@google.com>
  • Loading branch information
Thiago Perrotta and WeizhongX authored Nov 17, 2023
1 parent 8312aff commit 705365b
Showing 1 changed file with 9 additions and 7 deletions.
16 changes: 9 additions & 7 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -458,15 +458,17 @@ third_party/bidimapper/build.sh
```

3. Submit a CL with bug `chromedriver:4226`.
4. [Regenerate WPT expectations metadata](https://chromium.googlesource.com/chromium/src/+/HEAD/docs/testing/web_platform_tests_wptrunner.md#updating-expectations):

4.1. Trigger a build and test run:
4. [Regenerate WPT expectations or baselines](https://chromium.googlesource.com/chromium/src/+/HEAD/docs/testing/run_web_platform_tests.md#test-expectations-and-baselines):

```shell
third_party/blink/tools/blink_tool.py update-metadata --build="linux-blink-rel" --verbose
```
4.1. Trigger a build and test run:

```shell
third_party/blink/tools/blink_tool.py rebaseline-cl --build="linux-blink-rel" --verbose
```

4.2. Once the test completes on the builder, rerun that command to update the metadata.
Commit the changes (if any), and upload the new patch to the CL.
4.2. Once the test completes on the builder, rerun that command to update the
baselines. Update test expectations if there are any crashes or timeouts.
Commit the changes (if any), and upload the new patch to the CL.

5. Add appropriate reviewers or comment the CL link on the PR.

0 comments on commit 705365b

Please sign in to comment.