Resume tab target from page taregt

GoogleChromeLabs · Oct 9, 2024 · e745e75 · e745e75
1 parent 94e8b35
commit e745e75
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/src/bidiMapper/modules/cdp/CdpTarget.ts b/src/bidiMapper/modules/cdp/CdpTarget.ts
@@ -173,6 +173,8 @@ export class CdpTarget {
         }),
         this.#initAndEvaluatePreloadScripts(),
         this.#cdpClient.sendCommand('Runtime.runIfWaitingForDebugger'),
+        // Resume tab execution as well if it was paused by the debugger.
+        this.#parentCdpClient.sendCommand('Runtime.runIfWaitingForDebugger'),
         this.toggleDeviceAccessIfNeeded(),
       ]);
     } catch (error: any) {

diff --git a/src/bidiMapper/modules/cdp/CdpTargetManager.ts b/src/bidiMapper/modules/cdp/CdpTargetManager.ts
@@ -204,14 +204,15 @@ export class CdpTargetManager {
         // Tab targets are required only to handle page targets beneath them.
         this.#setEventListeners(targetCdpClient);
 
-        // Auto-attach to the page target and resume the tab target.
+        // Auto-attach to the page target and resume the tab target. No need in resuming
+        // tab target debugger, as it should preserve the page target debugger state, and
+        // will be resumed by the page target.
         void (async () => {
           await targetCdpClient.sendCommand('Target.setAutoAttach', {
             autoAttach: true,
             waitForDebuggerOnStart: true,
             flatten: true,
           });
-          await targetCdpClient.sendCommand('Runtime.runIfWaitingForDebugger');
         })();
         return;
       case 'page':