chore: address comments

GoogleChromeLabs · Oct 17, 2024 · f41dba9 · f41dba9
1 parent 7c03e2c
commit f41dba9
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/src/bidiMapper/modules/cdp/CdpTarget.ts b/src/bidiMapper/modules/cdp/CdpTarget.ts
@@ -302,6 +302,12 @@ export class CdpTarget {
         blockedRequest.map((request) => request.waitNextPhase)
       )
         .then(async () => {
+          const blockedRequest = this.#networkStorage
+            .getRequestsByTarget(this)
+            .filter((request) => request.interceptPhase);
+          if (blockedRequest.length) {
+            return await this.toggleFetchIfNeeded();
+          }
           return await this.#cdpClient.sendCommand('Fetch.disable');
         })
         .catch((error) => {

diff --git a/src/bidiMapper/modules/network/NetworkRequest.ts b/src/bidiMapper/modules/network/NetworkRequest.ts
@@ -733,7 +733,7 @@ export class NetworkRequest {
   }
 
   dispose() {
-    this.waitNextPhase.reject(new Error());
+    this.waitNextPhase.reject(new Error('waitNextPhase disposed'));
   }
 
   async #continueWithAuth(