fix: implement less flaky network module #1871
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lightning00Blade
force-pushed
the
remove-deferred
branch
4 times, most recently
from
5f9c76c to
c03b43f
Compare
Lightning00Blade
added a commit
that referenced
this pull request
Feb 23, 2024
Extracted from #1871.
Lightning00Blade
force-pushed
the
remove-deferred
branch
from
064aebc to
ef65475
Compare
OrKoN
reviewed
Feb 26, 2024
OrKoN
reviewed
Feb 26, 2024
OrKoN
reviewed
Feb 26, 2024
OrKoN
reviewed
Feb 26, 2024
OrKoN
reviewed
Feb 26, 2024
wpt-metadata/mapper/headless/webdriver/tests/bidi/network/add_intercept/url_patterns.py.ini
Outdated
Show resolved
Hide resolved
Lightning00Blade
force-pushed
the
remove-deferred
branch
2 times, most recently
from
d65b954 to
33803f6
Compare
|
Looks like perform_actions/invalid.py times out consistently |
OrKoN
reviewed
Feb 27, 2024
wpt-metadata/mapper/headful/webdriver/tests/bidi/network/add_intercept/url_patterns.py.ini
Show resolved
Hide resolved
OrKoN
approved these changes
Feb 27, 2024
Lightning00Blade
force-pushed
the
remove-deferred
branch
from
33803f6 to
7df5c5e
Compare
Lightning00Blade
changed the title
|
@Lightning00Blade please update the description with the summary of the fix |
Lightning00Blade
force-pushed
the
remove-deferred
branch
2 times, most recently
from
6ffb705 to
2b3aebe
Compare
OrKoN
approved these changes
Feb 27, 2024
Lightning00Blade
force-pushed
the
remove-deferred
branch
from
1cc542f to
ec4085e
Compare
sadym-chromium
pushed a commit
that referenced
this pull request
Feb 29, 2024
🤖 I have created a release *beep* *boop* --- ## [0.5.12](chromium-bidi-v0.5.11...chromium-bidi-v0.5.12) (2024-02-29) ### Features * implement `storage.deleteCookies` ([#1915](#1915)) ([18d3d4f](18d3d4f)) ### Bug Fixes * implement less flaky network module ([#1871](#1871)) ([4ec8bad](4ec8bad)) * parse `browser.RemoveUserContextParameters` ([#1905](#1905)) ([a50821b](a50821b)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
sadym-chromium
added a commit
to puppeteer/puppeteer
that referenced
this pull request
Feb 29, 2024
## [0.5.12](GoogleChromeLabs/chromium-bidi@chromium-bidi-v0.5.11...chromium-bidi-v0.5.12) (2024-02-29) ### Features * implement `storage.deleteCookies` ([#1915](GoogleChromeLabs/chromium-bidi#1915)) ([18d3d4f](GoogleChromeLabs/chromium-bidi@18d3d4f)) ### Bug Fixes * implement less flaky network module ([#1871](GoogleChromeLabs/chromium-bidi#1871)) ([4ec8bad](GoogleChromeLabs/chromium-bidi@4ec8bad)) * parse `browser.RemoveUserContextParameters` ([#1905](GoogleChromeLabs/chromium-bidi#1905)) ([a50821b](GoogleChromeLabs/chromium-bidi@a50821b))
This was referenced Mar 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
NetworkStorageis the entry point of all request we store bothrequestsandinteceptsin it.Each CDP event should try to get get a request and if not create it, that way the EventLifecycle of the Request is handle only by the
NetworkRequestclass.Now Network events are non-blocking (we may want to revert part of this if we encounter flakiness).
To achieve this we have heuristics that determine when an event should be emitted.
These heuristics are backed up by Unit tests so that it's have easier way of reproducing different behavior when it comes to how events are ordered or if emitted at all from CDP.
#network-interception-2024