feat: implement browser.getClientWindows
#2780
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sadym-chromium
force-pushed
the
sadym/browser-getClientWindows
branch
from
b31dcb0 to
5dbcc6c
Compare
sadym-chromium
force-pushed
the
sadym/browser-getClientWindows
branch
from
45f986a to
488083f
Compare
OrKoN
approved these changes
Nov 15, 2024
3 tasks
OrKoN
reviewed
Nov 15, 2024
| return { | ||
| // Is not supported in CDP yet. | ||
| active: false, | ||
| clientWindow: `${windowInfo.windowId}`, |
There was a problem hiding this comment.
I think the spec returns each window only once https://w3c.github.io/webdriver-bidi/#command-browser-getClientWindows
sadym-chromium
added a commit
that referenced
this pull request
Nov 18, 2024
) Addressing issue pointed in #2780 (comment) --------- Co-authored-by: Alex Rudenko <OrKoN@users.noreply.github.com>
sadym-chromium
pushed a commit
that referenced
this pull request
Nov 25, 2024
🤖 I have created a release *beep* *boop* --- ## [0.10.1](chromium-bidi-v0.10.0...chromium-bidi-v0.10.1) (2024-11-25) ### Features * do not emit initial navigation events ([#2796](#2796)) ([c8c9cdf](c8c9cdf)) * implement `browser.getClientWindows` ([#2780](#2780)) ([7b91906](7b91906)) ### Bug Fixes * `browser.getClientWindows` returns a unique per window value ([#2783](#2783)) ([0f97130](0f97130)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing #2777